Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database setup step in wasp start reports success even when it fails #2327

Open
Martinsos opened this issue Oct 8, 2024 · 1 comment
Open
Labels
dx shouldfix We should do/fix this at some point

Comments

@Martinsos
Copy link
Member

Run wasp start without database running, for waspc/examples/todoApp. Database setup step will print errors to stderr but it won't recognize failure. It should recognize failure and not report success! I am not sure if we should fail wasp start at that point or not, but even if not, we need that error to be visibly reported and obvious, because it will cause other errors messages below that make you completely miss the real source.

image

@Martinsos
Copy link
Member Author

Btw, it does stop with nice error message in wasp db migrate-dev, because there we have that precondition / require check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx shouldfix We should do/fix this at some point
Projects
None yet
Development

No branches or pull requests

1 participant