Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Long Applicant Name Issue #22

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tahazaryab
Copy link

@tahazaryab tahazaryab commented Feb 2, 2023

CLICKUP TICKET LINK

Summary

  • Issue: An applicant with a longer name (that causes it to be broken up into multiple lines) was causing the header div to cover/hide the rest of the components on /recruitment/interview/<any_id> and /recruitment/applicant/<any_id>
  • Change: Padding and position styles were updated to ensure that the header component does not cover other existing components when the height increases

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing Instructions

To manually test the style changes on the frontend:

  • Navigate to /recruitment/interview/<any_id> where <any_id> can be random characters, or correspond to a test applicant if created
  • Add/update the existing h1 tag by inspecting representing the name of the applicant to a longer name that may take up multiple lines, for example, "ThisIsALongFirstName ThisIsAVeryVeryVeryVeryLongLastName" (can be done using inspect element in your browser)
    • Ensure that the header div does not cover/hide any of the remaining components on the page (meaning that we are able to view both the Full Name of the applicant, as well as the rest of the components in the main content)

Note:

  • These changes also apply to /recruitment/application/<any_id>

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation/READ-ME/UMLS (if applicable)
  • My changes generate no new warnings

@tahazaryab tahazaryab added the bug Something isn't working label Feb 2, 2023
@tahazaryab tahazaryab self-assigned this Feb 2, 2023
@jennchenn
Copy link

@tahazaryab tahazaryab changed the title Cu 860pnapxx/profile long name issue tzaryab Fix Long Applicant Name Issue Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants