Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes to README file. #103

Merged
merged 3 commits into from
Sep 6, 2022
Merged

Conversation

keep94
Copy link
Contributor

@keep94 keep94 commented Sep 1, 2022

No description provided.

Copy link
Contributor

@oppegard oppegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should definitely automate most/all of this into a GitHub Action that we can manually trigger: https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow.

The input to the action would be the new version, e.g. v0.10.3.

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@shavidissa shavidissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor comments :)
Minor nitpick: Can we add a full stop to all the sentences? Some have it and some don't.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@keep94
Copy link
Contributor Author

keep94 commented Sep 2, 2022

Thank you oppegard and shavidissa for your comments.

Copy link
Contributor

@shavidissa shavidissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@keep94 keep94 merged commit 2fa3be5 into wavefrontHQ:master Sep 6, 2022
@keep94 keep94 deleted the release-notes branch September 6, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants