Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: authentication using CSP #148

Merged
merged 1 commit into from
Aug 30, 2023
Merged

feat: authentication using CSP #148

merged 1 commit into from
Aug 30, 2023

Conversation

LukeWinikates
Copy link
Contributor

No description provided.

LukeWinikates
LukeWinikates commented Aug 18, 2023
View reviewed changes
senders/client_test.go Outdated Show resolved Hide resolved
LukeWinikates
LukeWinikates commented Aug 18, 2023
View reviewed changes
test/helpers.go Outdated Show resolved Hide resolved
LukeWinikates
LukeWinikates commented Aug 18, 2023
View reviewed changes
Copy link
Contributor Author

@LukeWinikates LukeWinikates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added several comments

@LukeWinikates LukeWinikates mentioned this pull request Aug 23, 2023
Closed
@LukeWinikates LukeWinikates force-pushed the K8SSAAS-2215-csp branch 2 times, most recently from 6f39406 to d88633b Compare August 24, 2023 15:58
@LukeWinikates
Copy link
Contributor Author

LukeWinikates commented Aug 28, 2023 •
edited
Loading

  • needs orgID option
  • support ALL PERMISSIONS scope we dropped the SDK-side scope check instead, because it's redundant given that the server will be doing the checks.

@LukeWinikates LukeWinikates force-pushed the K8SSAAS-2215-csp branch 2 times, most recently from afd31b3 to 1f9f983 Compare August 30, 2023 18:06
@ernst-riemer @LukeWinikates
feat: authentication using CSP
bdd9b79 
Signed-off-by: Ernst Riemer <[email protected]>
Signed-off-by: Luke Winikates <[email protected]>
@LukeWinikates LukeWinikates merged commit 4aa3472 into master Aug 30, 2023
3 checks passed
@LukeWinikates LukeWinikates deleted the K8SSAAS-2215-csp branch October 11, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyaselvaganesan priyaselvaganesan priyaselvaganesan approved these changes

@suprajanarasimhan suprajanarasimhan Awaiting requested review from suprajanarasimhan

@jbooherl jbooherl Awaiting requested review from jbooherl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukeWinikates @priyaselvaganesan @ernst-riemer