Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable errcheck linter and resolve linter warnings #167

Merged
merged 1 commit into from
Sep 28, 2023
Merged

chore: enable errcheck linter and resolve linter warnings #167

merged 1 commit into from
Sep 28, 2023

Conversation

LukeWinikates
Copy link
Contributor

No description provided.

suprajanarasimhan
suprajanarasimhan approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@suprajanarasimhan suprajanarasimhan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this change enables a linter for identifying and correcting unchecked errors.
The two types of corrections I see:

  • Assert that code in tests doesn't return errors.
  • Add underscores to indicate intentionally ignored errors.

Neat!

@LukeWinikates LukeWinikates merged commit 971d46f into master Sep 28, 2023
3 checks passed
@LukeWinikates LukeWinikates deleted the errcheck branch October 11, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suprajanarasimhan suprajanarasimhan suprajanarasimhan approved these changes

@jbooherl jbooherl jbooherl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukeWinikates @suprajanarasimhan @jbooherl