Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement wazuh agent daemon mode #178

Open
wants to merge 7 commits into
base: enhancement/140-daemon-mode
Choose a base branch
from
Open

Implement wazuh agent daemon mode #178

wants to merge 7 commits into from
+504 −145

Conversation

aritosteles
Copy link
Contributor

Related issue
141

Description

This PR aims to make wazuh-agent run in the background and support CLI commands start, status and stop.

  • Compilation without warnings in every supported platform
    • Linux
    • Windows
    • MAC OS X

@aritosteles aritosteles linked an issue Sep 25, 2024 that may be closed by this pull request
Implement Wazuh Agent Daemon Mode #140
Open
@aritosteles aritosteles removed a link to an issue Sep 25, 2024
Implement Wazuh Agent Daemon Mode #140
Open
@aritosteles aritosteles linked an issue Sep 25, 2024 that may be closed by this pull request
Implement Daemon Mode for UNIX-based Systems (Linux, macOS) #141
Open
@aritosteles aritosteles force-pushed the enhancement/140-implement-wazuh-agent-daemon-mode branch from b1331ac to 8f38f93 Compare September 25, 2024 22:07
@aritosteles aritosteles mentioned this pull request Sep 25, 2024
Open
TomasTurina
TomasTurina reviewed Sep 26, 2024
View reviewed changes
src/CMakeLists.txt Outdated Show resolved Hide resolved
@aritosteles aritosteles force-pushed the enhancement/140-implement-wazuh-agent-daemon-mode branch 3 times, most recently from 501b283 to f294c8e Compare September 26, 2024 17:50
jr0me
jr0me reviewed Sep 26, 2024
View reviewed changes
Copy link
Member

@jr0me jr0me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specifics of the daemonization look good! yet I think we should think a bit further how we are separating code. Having header files that are platform specific in the public include folder is a hint that something can be improved.

src/agent/include/register.hpp Outdated Show resolved Hide resolved
src/agent/src/register.cpp Outdated Show resolved Hide resolved
src/agent/src/unix_daemon.cpp Outdated Show resolved Hide resolved
@aritosteles aritosteles force-pushed the enhancement/140-implement-wazuh-agent-daemon-mode branch 2 times, most recently from d4f3f98 to 1708bb5 Compare September 26, 2024 21:21
@aritosteles aritosteles force-pushed the enhancement/140-implement-wazuh-agent-daemon-mode branch 7 times, most recently from 63e91df to 00c514b Compare October 2, 2024 21:44
jr0me
jr0me reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@jr0me jr0me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some additional comments. The one that looks like a must fix is the change in the vcpkg submodule hash.

Also, if possible, some commits are doing more than what the commit message states and some fixes could be made at the point what they are fixing was introduced.

src/CMakeLists.txt Outdated Show resolved Hide resolved
src/vcpkg Outdated Show resolved Hide resolved
src/agent/src/agent_registration.cpp Outdated Show resolved Hide resolved
src/agent/src/unix_daemon.cpp Outdated Show resolved Hide resolved
src/agent/src/unix_daemon.cpp Outdated Show resolved Hide resolved
src/agent/src/unix_daemon.cpp Outdated Show resolved Hide resolved
src/agent/src/unix_daemon.cpp Outdated Show resolved Hide resolved
src/agent/src/unix_daemon.cpp Outdated Show resolved Hide resolved
src/agent/include/agent_registration.hpp
std::string password;
};

class AgentRegistration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't you referring to the UnixDaemon class?

src/agent/include/unix_daemon.hpp Outdated Show resolved Hide resolved
@sdvendramini sdvendramini mentioned this pull request Oct 3, 2024
Open
3 tasks
@aritosteles aritosteles force-pushed the enhancement/140-implement-wazuh-agent-daemon-mode branch 7 times, most recently from 71c18c5 to 3d64627 Compare October 3, 2024 23:30
@aritosteles aritosteles force-pushed the enhancement/140-implement-wazuh-agent-daemon-mode branch from 3d64627 to c7ccdbb Compare October 4, 2024 15:19
@jr0me jr0me self-requested a review October 4, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicogp Nicogp Nicogp approved these changes

@jr0me jr0me jr0me approved these changes

@sdvendramini sdvendramini Awaiting requested review from sdvendramini

@TomasTurina TomasTurina Awaiting requested review from TomasTurina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Daemon Mode for UNIX-based Systems (Linux, macOS)
5 participants
@aritosteles @sdvendramini @TomasTurina @Nicogp @jr0me