Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows communication using https #189

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Allows communication using https #189

merged 3 commits into from
Oct 1, 2024

Conversation

Nicogp
Copy link
Member

@Nicogp Nicogp commented Sep 30, 2024 •
edited
Loading

Related issue
#158

Description

This PR adds the changes to allow communication using https. It also adds a configuration option “https_enabled” to allow the use of http or https.

Tests

  • Compilation without warnings in every supported platform
    • Linux
    • Windows
    • MAC OS X

@Nicogp Nicogp force-pushed the enhancement/158-support-https branch 18 times, most recently from 0d2092a to e6a54b2 Compare October 1, 2024 03:20
jr0me
jr0me reviewed Oct 1, 2024
View reviewed changes
src/agent/communicator/src/http_socket_factory.hpp Outdated Show resolved Hide resolved
src/agent/communicator/src/communicator.cpp Outdated Show resolved Hide resolved
src/agent/src/register.cpp Outdated Show resolved Hide resolved
src/agent/communicator/src/http_socket.hpp Outdated Show resolved Hide resolved
@Nicogp Nicogp force-pushed the enhancement/158-support-https branch 3 times, most recently from c59384a to 3d008e1 Compare October 1, 2024 12:01
@Nicogp Nicogp force-pushed the enhancement/158-support-https branch 2 times, most recently from fd279f5 to 12cfcbf Compare October 1, 2024 12:52
@Nicogp Nicogp force-pushed the enhancement/158-support-https branch from 12cfcbf to e89656b Compare October 1, 2024 14:01
@Nicogp Nicogp marked this pull request as ready for review October 1, 2024 14:28
@Nicogp Nicogp linked an issue Oct 1, 2024 that may be closed by this pull request
Implement HTTPS support in the network wrapper #158
Closed
4 tasks
@jr0me jr0me self-requested a review October 1, 2024 15:31
@TomasTurina TomasTurina merged commit 5ad2356 into master Oct 1, 2024
5 checks passed
@TomasTurina TomasTurina deleted the enhancement/158-support-https branch October 1, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasTurina TomasTurina TomasTurina approved these changes

@jr0me jr0me jr0me approved these changes

@sdvendramini sdvendramini Awaiting requested review from sdvendramini

@aritosteles aritosteles Awaiting requested review from aritosteles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement HTTPS support in the network wrapper
3 participants
@Nicogp @TomasTurina @jr0me