Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added page scroll with many events in inventory table #7065

Open
wants to merge 2 commits into
base: 4.10.0
Choose a base branch
from
Open

Added page scroll with many events in inventory table #7065

wants to merge 2 commits into from

Conversation

JuanGarriuz
Copy link
Member

Description

Change the truncated height to a min-height value.

Issues Resolved

Evidence

Grabacion.2024-09-25.165509.mp4

Test

  • Check that the inventory table render correctly the changes of selected rows per page

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz self-assigned this Oct 4, 2024
@JuanGarriuz JuanGarriuz linked an issue Oct 4, 2024 that may be closed by this pull request
Improve the events page #7049
Open
14 tasks
@JuanGarriuz JuanGarriuz mentioned this pull request Oct 4, 2024
Open
14 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Main plugin code coverage (Jest) test % values
Statements 14.09% ( 4177 / 29637 )
Branches 9.22% ( 1779 / 19293 )
Functions 13.74% ( 985 / 7166 )
Lines 14.28% ( 4075 / 28523 )

guidomodarelli
guidomodarelli approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 👍
TEST 👍

Before

I cant scroll down
image

After

Peek.2024-10-04.15-34.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidomodarelli guidomodarelli guidomodarelli approved these changes

Assignees

@JuanGarriuz JuanGarriuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the events page
2 participants
@JuanGarriuz @guidomodarelli