Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary plugins from default Wazuh dashboard to 4.3 #1568

Merged
merged 2 commits into from
May 24, 2022

Conversation

c-bordon
Copy link
Member

Related issue
closes #1564

Description

The plugins mentioned in the issue are removed and various changes are applied to the dashboard checkfiles database

Before uninstall:
Screenshot_20220523_151749

After uninstall:
Screenshot_20220523_154439

Builds:
RPM: https://devel.ci.wazuh.info/view/Packages/job/Packages_builder/7603/console
DEB: https://devel.ci.wazuh.info/view/Packages/job/Packages_builder/7605/console

Tests install:

Centos 7: https://devel.ci.wazuh.info/view/Tests/job/Test_install_stack/469/console

Ubuntu focal: https://devel.ci.wazuh.info/view/Tests/job/Test_install_stack/464/

@c-bordon c-bordon requested review from alberpilot and okynos and removed request for alberpilot May 24, 2022 14:54
@c-bordon c-bordon self-assigned this May 24, 2022
@github-actions
Copy link
Contributor

./artifacts_generated/builder.sh:12:10:warning:Declare and assign separately to avoid masking return values.
./artifacts_generated/builder.sh:18:10:warning:resources_download appears unused. Verify use (or export if used externally).
./artifacts_generated/builder.sh:69:9:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:73:14:info:Expressions don't expand in single quotes, use double quotes for that.
./artifacts_generated/builder.sh:77:9:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:80:14:info:Expressions don't expand in single quotes, use double quotes for that.
./artifacts_generated/builder.sh:84:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:85:25:info:Double quote to prevent globbing and word splitting.
./artifacts_generated/builder.sh:89:26:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:90:23:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:90:37:error:Double quote array expansions to avoid re-splitting elements.
./artifacts_generated/builder.sh:90:37:error:Argument mixes string and array. Use * or separate argument.
./artifacts_generated/builder.sh:90:37:warning:The surrounding quotes actually unquote this. Remove or escape them.
./artifacts_generated/builder.sh:90:37:warning:eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string).
./artifacts_generated/builder.sh:92:62:style:Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
./artifacts_generated/builder.sh:103:22:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:104:28:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:107:13:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:108:54:info:Double quote to prevent globbing and word splitting.
./artifacts_generated/builder.sh:114:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:140:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:155:24:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:156:30:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:156:44:error:Double quote array expansions to avoid re-splitting elements.
./artifacts_generated/builder.sh:156:44:error:Argument mixes string and array. Use * or separate argument.
./artifacts_generated/builder.sh:156:44:warning:The surrounding quotes actually unquote this. Remove or escape them.
./artifacts_generated/builder.sh:156:44:warning:eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string).
./artifacts_generated/builder.sh:159:13:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:166:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:180:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:195:20:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:196:26:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:196:40:error:Double quote array expansions to avoid re-splitting elements.
./artifacts_generated/builder.sh:196:40:error:Argument mixes string and array. Use * or separate argument.
./artifacts_generated/builder.sh:196:40:warning:The surrounding quotes actually unquote this. Remove or escape them.
./artifacts_generated/builder.sh:196:40:warning:eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string).
./artifacts_generated/builder.sh:199:13:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:206:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:248:19:info:Double quote to prevent globbing and word splitting.
./artifacts_generated/builder.sh:253:19:info:Double quote to prevent globbing and word splitting.
./artifacts_generated/builder.sh:258:19:info:Double quote to prevent globbing and word splitting.

Copy link
Contributor

@DFolchA DFolchA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

./artifacts_generated/builder.sh:12:10:warning:Declare and assign separately to avoid masking return values.
./artifacts_generated/builder.sh:18:10:warning:resources_download appears unused. Verify use (or export if used externally).
./artifacts_generated/builder.sh:69:9:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:73:14:info:Expressions don't expand in single quotes, use double quotes for that.
./artifacts_generated/builder.sh:77:9:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:80:14:info:Expressions don't expand in single quotes, use double quotes for that.
./artifacts_generated/builder.sh:84:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:85:25:info:Double quote to prevent globbing and word splitting.
./artifacts_generated/builder.sh:89:26:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:90:23:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:90:37:error:Double quote array expansions to avoid re-splitting elements.
./artifacts_generated/builder.sh:90:37:error:Argument mixes string and array. Use * or separate argument.
./artifacts_generated/builder.sh:90:37:warning:The surrounding quotes actually unquote this. Remove or escape them.
./artifacts_generated/builder.sh:90:37:warning:eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string).
./artifacts_generated/builder.sh:92:62:style:Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
./artifacts_generated/builder.sh:103:22:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:104:28:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:107:13:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:108:54:info:Double quote to prevent globbing and word splitting.
./artifacts_generated/builder.sh:114:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:140:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:155:24:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:156:30:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:156:44:error:Double quote array expansions to avoid re-splitting elements.
./artifacts_generated/builder.sh:156:44:error:Argument mixes string and array. Use * or separate argument.
./artifacts_generated/builder.sh:156:44:warning:The surrounding quotes actually unquote this. Remove or escape them.
./artifacts_generated/builder.sh:156:44:warning:eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string).
./artifacts_generated/builder.sh:159:13:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:166:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:180:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:195:20:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:196:26:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:196:40:error:Double quote array expansions to avoid re-splitting elements.
./artifacts_generated/builder.sh:196:40:error:Argument mixes string and array. Use * or separate argument.
./artifacts_generated/builder.sh:196:40:warning:The surrounding quotes actually unquote this. Remove or escape them.
./artifacts_generated/builder.sh:196:40:warning:eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string).
./artifacts_generated/builder.sh:199:13:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:206:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:248:19:info:Double quote to prevent globbing and word splitting.
./artifacts_generated/builder.sh:253:19:info:Double quote to prevent globbing and word splitting.
./artifacts_generated/builder.sh:258:19:info:Double quote to prevent globbing and word splitting.

@alberpilot alberpilot merged commit 30061c4 into 4.3 May 24, 2022
@alberpilot alberpilot deleted the 1564-RemoveDashboardPlugins-to4.3 branch May 24, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants