-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support empty ruleset/sca directories #2256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikman90
requested review from
DFolchA and
rauldpm
and removed request for
DFolchA
July 7, 2023 11:04
30 tasks
vikman90
force-pushed
the
2197-fix-sca-wildcard
branch
from
July 7, 2023 11:22
a44ac49
to
62f2d3c
Compare
DFolchA
approved these changes
Jul 7, 2023
rauldpm
approved these changes
Jul 7, 2023
rauldpm
approved these changes
Jul 7, 2023
jnasselle
approved these changes
Jul 7, 2023
Fixes #2196 Alter the chmod and chown lines to not assume there are files in the directory. Impact if there are files is unchanged.
jotacarma90
force-pushed
the
2197-fix-sca-wildcard
branch
from
July 7, 2023 19:06
619dc51
to
5e69a36
Compare
TestingVagrant box used: ManagerOutput:
AgentOutput:
Checking agent logs, we can see how it connects with the manager and all the modules are running normally with the default configuration.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a port of #2197 by @lod. This replaces
chmod
on all the SCA policies available (*
) with a recursive option (--recursive
). This way, we avoid a "No such file or directory" error if the sca folder contains no policy files.