Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wazuh favicon does not appear in safari #2789

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

yenienserrano
Copy link
Member

Related issue
#2788

Description

Renamed favicon image for safari
Remove the color of the favicon so that it has the colors of Wazuh

image

Tests

  • Build the package in any supported platform
    • Linux
    • Windows
    • macOS
    • Solaris
    • AIX
    • HP-UX
  • Package installation
  • Package upgrade
  • Package downgrade
  • Package remove
  • Package install/remove/install
  • Change added to CHANGELOG.md
  • Tests for Linux RPM
    • Build the package for x86_64
    • Build the package for i386
    • Build the package for armhf
    • Build the package for aarch64
    • %files section is correctly updated if necessary
  • Tests for Linux deb
    • Build the package for x86_64
    • Build the package for i386
    • Build the package for armhf
    • Build the package for aarch64
    • Package install/remove/install
    • Package install/purge/install
    • Check file permissions after installing the package
  • Tests for macOS
    • Test the package from macOS Sierra to Mojave
  • Tests for Solaris
    • Test the package on Solaris 10
    • Test the package on Solaris 11
    • Check file permissions on Solaris 11 template
  • Tests for IBM AIX
    • %files section is correctly updated if necessary
    • Check the changes from IBM AIX 5 to 7

@yenienserrano yenienserrano linked an issue Jan 22, 2024 that may be closed by this pull request
@yenienserrano yenienserrano self-assigned this Jan 22, 2024
Copy link
Member

@rauldpm rauldpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please, add another review from @wazuh/frontend team, changing the issue status to Pending review again

Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asteriscos asteriscos changed the title Fix/2788 wazuhs favicon does not appear in safari Wazuh favicon does not appear in safari Jan 24, 2024
@asteriscos asteriscos merged commit 4ca31b3 into 4.8.0 Jan 24, 2024
4 checks passed
@asteriscos asteriscos deleted the fix/2788-wazuhs-favicon-does-not-appear-in-safari branch January 24, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wazuh's favicon does not appear in safari
4 participants