Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the NVD's VD System Tests support #4302

Closed
Tracked by #16555
mateocervilla opened this issue Jul 10, 2023 · 6 comments · Fixed by #4372
Closed
Tracked by #16555

Modify the NVD's VD System Tests support #4302

mateocervilla opened this issue Jul 10, 2023 · 6 comments · Fixed by #4372

Comments

@mateocervilla
Copy link
Contributor

mateocervilla commented Jul 10, 2023

Related issue
#4275

Description

After the following changes in the NVD: wazuh/wazuh#16555, it is necessary to deprecate some fields on the tests.
Work is being done on the integration tests on the related issue but the system tests needs to be reviewed.

The tag update_from_year from Vulnerability Detector seems to be present in the mentioned tests, apparently as templates:

For example in:

  • system/provisioning/

    • agentless_cluster/roles/
      • master-role/files/ossec.conf
      • worker-role/files/ossec.conf
    • basic_cluster/roles/
      • master-role/files/ossec.conf
      • worker-role/files/ossec.conf
    • big_cluster_40_agents/roles
      • master-role/files/ossec.conf
      • worker-role/files/ossec.conf
    • enrollment_cluster/roles
      • master-role/files/ossec.conf
      • worker-role/files/ossec.conf
    • four_manager_disconnected_node/roles
      • master-role/files/ossec.conf
      • worker-role/files/ossec.conf
    • manager_agent/roles
      • manager-role/files/ossec.conf
      • master-role/files/ossec.conf
    • one_manager_agent/roles/manager-role/files/ossec.conf
  • end_to_end/test_basic_cases/test_vulnerability_detector/

    • test_vulnerability_detector_linux/data/playbooks/configuration.yaml
    • test_vulnerability_detector_windows/data/playbooks/configuration.yaml

We can find:

<provider name="nvd">
    <enabled>no</enabled>
    <update_from_year>2010</update_from_year>
    <update_interval>1h</update_interval>
</provider>
@juliamagan
Copy link
Member

Update

Deleted update_from_year occurrences from system and E2E tests and created PR.

@juliamagan
Copy link
Member

juliamagan commented Jul 31, 2023

Update

Moved back to In progress, because the executions failed.

Edit: After some tests and research, the following issue was found:

@juliamagan
Copy link
Member

Update

Since wazuh/wazuh#18168 has been solved, we have launched the tests again.

@juliamagan
Copy link
Member

juliamagan commented Aug 2, 2023

Update

Moved back to In progress, because the executions failed.

They failed because they were launched with the old package.

When we launch with the expected package, the pipeline does not take the one we have passed by parameters. The following issue has been opened:

@mauromalara
Copy link
Contributor

mauromalara commented Aug 2, 2023

Review comment No.1

PR approved ✅

⚠️ Remember to add the error displayed in the job in Jenkins to the reported bug (https://github.com/wazuh/wazuh-jenkins/issues/5489) - I will add it to the issue this time.

05:26:13  org.wazuh.JenkinsException: Provisioning errorThe given package parameters([version:4.5.0, revision:1, repository:warehouse-pullrequests]) return an unvalid package: ...

@davidjiglesias
Copy link
Member

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants