Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete update_from_year from system and E2E tests #4372

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

juliamagan
Copy link
Member

@juliamagan juliamagan commented Jul 28, 2023

Related issue
#4302

Description

Since update_from_year is deprecated, we have deleted it from our templates

Updated

  • tests/end_to_end/test_basic_cases/test_vulnerability_detector/test_vulnerability_detector_linux/data/playbooks/configuration.yaml
  • tests/end_to_end/test_basic_cases/test_vulnerability_detector/test_vulnerability_detector_windows/data/playbooks/configuration.yaml
  • tests/system/provisioning/agentless_cluster/roles/master-role/files/ossec.conf
  • tests/system/provisioning/agentless_cluster/roles/worker-role/files/ossec.conf
  • tests/system/provisioning/basic_cluster/roles/master-role/files/ossec.conf
  • tests/system/provisioning/basic_cluster/roles/worker-role/files/ossec.conf
  • tests/system/provisioning/big_cluster_40_agents/roles/master-role/files/ossec.conf
  • tests/system/provisioning/big_cluster_40_agents/roles/worker-role/files/ossec.conf
  • tests/system/provisioning/enrollment_cluster/roles/master-role/files/ossec.conf
  • tests/system/provisioning/enrollment_cluster/roles/worker-role/files/ossec.conf
  • tests/system/provisioning/four_manager_disconnected_node/roles/master-role/files/ossec.conf
  • tests/system/provisioning/four_manager_disconnected_node/roles/worker-role/files/ossec.conf
  • tests/system/provisioning/manager_agent/roles/manager-role/files/ossec.conf
  • tests/system/provisioning/manager_agent/roles/master-role/files/ossec.conf
  • tests/system/provisioning/one_manager_agent/roles/manager-role/files/ossec.conf

Testing performed

We are going to test only the E2E tests, which are the ones that really use this configuration, the rest are simply in a template, in which the vulnerability detector is disabled.

In addition, the #4251 and #4252 changes have been brought in for testing, as the tests were as xfail.

Tester Test path Jenkins Local Commit Notes
@juliamagan (Developer) end_to_end/test_basic_cases/test_vulnerability_detector 🚫🚫🚫 🟢 🟢 🟢 358b15c
@user (Reviewer) ⚫⚫⚫ 🚫 🚫 🚫

@juliamagan juliamagan self-assigned this Jul 28, 2023
@juliamagan juliamagan linked an issue Jul 28, 2023 that may be closed by this pull request
Copy link
Contributor

@mauromalara mauromalara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidjiglesias davidjiglesias merged commit 9da6f68 into 4.5.0 Aug 2, 2023
4 checks passed
@davidjiglesias davidjiglesias deleted the enhancement/4302-deprecate-update-from-year branch August 2, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the NVD's VD System Tests support
3 participants