Fix manager_agent environment #4808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deblintrake09
changed the title
1 task
pro-akim
requested changes
Jan 5, 2024
| agent3_id: "003" | ||
| agent3_hostname: "wazuh-agent3" | ||
| agent3_key: "3333333333333333333333333333333333333333333333333333333333333333" | ||
| agent3_package: "https://packages.wazuh.com/4.x/apt/pool/main/w/wazuh-agent/wazuh-agent_4.2.5-1_amd64.deb" | ||
| agent3_package: "https://packages.wazuh.com/4.x/apt/pool/main/w/wazuh-agent/wazuh-agent_{{package_version}}-{{package_revision}}_amd64.deb" |
There was a problem hiding this comment.
The problem with this structure is that most of system test are executed using packages from packages-dev.com/pre-elease.
Example:
If ansible is executed using:
ansible-playbook -i inventory.yml playbook.yml --extra-vars='{"package_repository":"packages-dev", "repository": "pre-release", "package_version": "4.8.0", "package_revision": "1"}'
The provision of agent-3 will fail because the package in the URL will not exist:
TASK [roles/agent-role : Create log source] *****************************************************************************************************************************
changed: [wazuh-agent3]
TASK [roles/agent-role : Download package] ******************************************************************************************************************************
fatal: [wazuh-agent3]: FAILED! => changed=false
dest: /tmp/wazuh-agent.deb
elapsed: 0
msg: Request failed
response: 'HTTP Error 404: Not Found'
status_code: 404
url: https://packages.wazuh.com/4.x/apt/pool/main/w/wazuh-agent/wazuh-agent_4.8.0-1_amd64.deb
PLAY RECAP **************************************************************************************************************************************************************
localhost : ok=9 changed=5 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0
wazuh-agent1 : ok=12 changed=11 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0
wazuh-agent2 : ok=12 changed=11 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0
wazuh-agent3 : ok=4 changed=3 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0
wazuh-manager : ok=13 changed=12 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0
There was a problem hiding this comment.
Fixed in 9c8de59
davidjiglesias
deleted the
enhancement/4295-fix-manager-agent-environment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the
manager_agentenvironment used in System Tests so that it installs the tested version inagent3endpoint.Updated
manager_agent/vars/configurations.ymlfile to parametrizeagent3package version.manager_agent/playbook.ymlfile to specify each agent user.Testing performed
Create environment 🟢
agent1file permissions and statusagent2file permissions and statusagent3file permissions and statusLaunch tests 🟢