Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file descriptors threshold values #5073

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

fdalmaup
Copy link
Member

@fdalmaup fdalmaup commented Mar 5, 2024

Description

Closes wazuh/wazuh#22179. It updates the file descriptor values used as thresholds in the Cluster Performance tests for the 25 workers and 50000 agents case.

Testing performed

Validation Jenkins Local OS Commit Notes
test_cluster_performance.py ⚫⚫ 🟢 🟢 Ubuntu 22.04 wazuh/wazuh@c6cceb9 Nothing to highlight
Testing with v4.7.3-rc1 artifacts
:/wazuh-qa# for i in {1..3}; do python3 -m pytest tests/performance/test_cluster/test_cluster_performance/test_cluster_performance.py --artifacts_path='/wazuh-qa/artifacts4.7.3-rc1/' --n_workers=25 --n_agents=50000; done 
====================================================================== test session starts ======================================================================
platform linux -- Python 3.10.12, pytest-7.1.2, pluggy-1.4.0
rootdir: /wazuh-qa/tests, configfile: pytest.ini
plugins: html-3.1.1, metadata-3.1.1, testinfra-5.0.0
collected 1 item                                                                                                                                                

tests/performance/test_cluster/test_cluster_performance/test_cluster_performance.py .                                                                     [100%]

======================================================================= 1 passed in 0.70s =======================================================================
====================================================================== test session starts ======================================================================
platform linux -- Python 3.10.12, pytest-7.1.2, pluggy-1.4.0
rootdir: /wazuh-qa/tests, configfile: pytest.ini
plugins: html-3.1.1, metadata-3.1.1, testinfra-5.0.0
collected 1 item                                                                                                                                                

tests/performance/test_cluster/test_cluster_performance/test_cluster_performance.py .                                                                     [100%]

======================================================================= 1 passed in 0.71s =======================================================================
====================================================================== test session starts ======================================================================
platform linux -- Python 3.10.12, pytest-7.1.2, pluggy-1.4.0
rootdir: /wazuh-qa/tests, configfile: pytest.ini
plugins: html-3.1.1, metadata-3.1.1, testinfra-5.0.0
collected 1 item                                                                                                                                                

tests/performance/test_cluster/test_cluster_performance/test_cluster_performance.py .                                                                     [100%]

======================================================================= 1 passed in 0.71s =======================================================================

@fdalmaup fdalmaup self-assigned this Mar 5, 2024
@fdalmaup fdalmaup linked an issue Mar 5, 2024 that may be closed by this pull request
4 tasks
@fdalmaup fdalmaup force-pushed the fix/22179-performance-fd-thresholds branch from 8045c36 to c0e040a Compare March 6, 2024 18:27
@fdalmaup fdalmaup force-pushed the fix/22179-performance-fd-thresholds branch from c0e040a to 3d4d712 Compare March 6, 2024 18:31
@fdalmaup fdalmaup requested a review from GGP1 March 6, 2024 18:42
GGP1
GGP1 previously approved these changes Mar 7, 2024
Copy link
Member

@GGP1 GGP1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Selutario Selutario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These values look good to me. Just missing an entry in the changelog.

@fdalmaup fdalmaup force-pushed the fix/22179-performance-fd-thresholds branch from 0dbef4c to b0293d1 Compare March 7, 2024 17:37
Copy link
Contributor

@Selutario Selutario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging without QA approval since this only affects cluster-related tests.

@Selutario Selutario merged commit bdda354 into 4.8.0 Mar 7, 2024
4 checks passed
@Selutario Selutario deleted the fix/22179-performance-fd-thresholds branch March 7, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster file descriptors exceeding thresholds in performance tests
3 participants