Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enrollment cluster system test #5134

Merged
merged 19 commits into from
Apr 4, 2024
Merged

Fix enrollment cluster system test #5134

merged 19 commits into from
Apr 4, 2024

Conversation

Rebits
Copy link
Member

@Rebits Rebits commented Mar 21, 2024 •
edited
Loading

Description

This PR fixes enrollment cluster system tests

Testing performed

Validation Jenkins Local OS Commit Notes
🟢 R1.zip Nothing to highlight

@Rebits Rebits self-assigned this Mar 21, 2024
@Rebits Rebits linked an issue Mar 21, 2024 that may be closed by this pull request
System enrollment_cluster tests fail in 4.8.0-beta4 #5101
Closed
@Rebits Rebits marked this pull request as ready for review March 21, 2024 17:31
rafabailon
rafabailon previously approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@rafabailon rafabailon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliamagan
juliamagan requested changes Mar 22, 2024
View reviewed changes
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ, but the changelog entry is missing. In addition, we need to test this environment on different instance types until the results are stable.

@Rebits Rebits changed the title Fix test_group_sync_status system test Fix enrollment cluster system test Apr 3, 2024
@davidjiglesias davidjiglesias merged commit d784d5f into 4.8.0 Apr 4, 2024
2 of 4 checks passed
@davidjiglesias davidjiglesias deleted the fix/5101-system-tests branch April 4, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjiglesias davidjiglesias davidjiglesias approved these changes

@juliamagan juliamagan juliamagan approved these changes

@rafabailon rafabailon rafabailon left review comments

Assignees

@Rebits Rebits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System enrollment_cluster tests fail in 4.8.0-beta4
4 participants
@Rebits @davidjiglesias @rafabailon @juliamagan