Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted custom field from PUT /active-response performance test. #5612

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Deleted custom field from PUT /active-response performance test. #5612

merged 1 commit into from
Jul 26, 2024

Conversation

RamosFe
Copy link
Member

@RamosFe RamosFe commented Jul 25, 2024

Description

Deletes the field custom from the PUT /active-response request made in the API performance test.

Testing performed

Testing was performed in #5611 (comment)

@RamosFe RamosFe self-assigned this Jul 25, 2024
@RamosFe RamosFe linked an issue Jul 25, 2024 that may be closed by this pull request
Delete deprecated field in PUT /active-response performance test #5611
Closed
2 tasks
GGP1
GGP1 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@GGP1 GGP1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the test affected passed successfully.

@fdalmaup fdalmaup self-requested a review July 26, 2024 12:46
fdalmaup
fdalmaup approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@fdalmaup fdalmaup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juliamagan juliamagan merged commit 2e98c14 into 4.9.0 Jul 26, 2024
@juliamagan juliamagan deleted the fix/5611-delete-custom-field-active-response branch July 26, 2024 15:44
This was referenced Aug 2, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdalmaup fdalmaup fdalmaup approved these changes

@GGP1 GGP1 GGP1 approved these changes

@juliamagan juliamagan juliamagan approved these changes

Assignees

@RamosFe RamosFe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete deprecated field in PUT /active-response performance test
4 participants
@RamosFe @fdalmaup @GGP1 @juliamagan