Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected warnings in E2E vulnerability detection tests #5711

Merged
merged 16 commits into from
Sep 19, 2024

Conversation

Rebits
Copy link
Member

@Rebits Rebits commented Sep 3, 2024

Description

As specified in Unexpected errors and warnings in the vulnerability detection E2E tests, E2E vulnerability detection tests fail due to unexpected errors in the environment for the initial scan tests. These errors are expected in the test environment due to the removal and register of the same agents.
This PR includes some changes to avoid test fails due to these expected warnings and errors

More information at #5698 (comment)

Changes

  • Include a timeout to prevent connection errors
  • Check only errors and critical messages

Testing performed

Build: https://ci.wazuh.info/job/Test_e2e_system/384
Report: Test_e2e_system_386_test_vulnerability_detector.zip

Warning

Some failures due to known issues in the feed. Already reported in wazuh/wazuh#25506

@Rebits Rebits self-assigned this Sep 3, 2024
@Rebits Rebits changed the base branch from master to 4.9.1 September 3, 2024 16:32
@Rebits Rebits linked an issue Sep 3, 2024 that may be closed by this pull request
3 tasks
@Rebits Rebits force-pushed the bug/5698-include-timeout-prevent-network-errors branch from b131c8a to 9f22122 Compare September 3, 2024 16:34
@Rebits Rebits marked this pull request as ready for review September 4, 2024 09:08
jseg380
jseg380 previously approved these changes Sep 4, 2024
Copy link
Member

@jseg380 jseg380 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! Just a few minor changes.

CHANGELOG.md Outdated
@@ -8,6 +8,9 @@ All notable changes to this project will be documented in this file.

- Added support for macOS 14.6 to the Allocation module (Vagrant) ([#5671](https://github.com/wazuh/wazuh-qa/pull/5671)) \- (Framework)

### Fixed
- Fix unexpected warnings in E2E vulnerability detection tests ([#5711](https://github.com/wazuh/wazuh-qa/pull/5711/)) \- (Tests)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fix unexpected warnings in E2E vulnerability detection tests ([#5711](https://github.com/wazuh/wazuh-qa/pull/5711/)) \- (Tests)
- Fix unexpected warnings in E2E vulnerability detection tests ([#5711](https://github.com/wazuh/wazuh-qa/pull/5711)) \- (Framework + Tests)

Copy link
Member Author

@Rebits Rebits Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 916d903 and b37d69d

@juliamagan juliamagan merged commit 73e83c9 into 4.9.1 Sep 19, 2024
@juliamagan juliamagan deleted the bug/5698-include-timeout-prevent-network-errors branch September 19, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected errors and warnings in the vulnerability detection E2E tests
3 participants