Skip to content

Commit

Permalink
nvm just needed to update tox lol
Browse files Browse the repository at this point in the history
  • Loading branch information
wbarnha committed Mar 18, 2024
1 parent c215106 commit 8d61252
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 11 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ jobs:
cache: pip
cache-dependency-path: |
requirements-dev.txt
- id: install-aws-cli
uses: unfor19/install-aws-cli-action@v1
- name: Check Java installation
run: source travis_java_install.sh
- name: Pull Kafka releases
Expand All @@ -101,7 +99,6 @@ jobs:
python -m pip install --upgrade pip
python -m pip install tox tox-gh-actions
pip install .
pip install awscli --force-reinstall --upgrade
pip install -r requirements-dev.txt
- name: Test with tox
run: tox
Expand Down Expand Up @@ -156,8 +153,6 @@ jobs:
cache: pip
cache-dependency-path: |
requirements-dev.txt
- id: install-aws-cli
uses: unfor19/install-aws-cli-action@v1
- name: Pull Kafka releases
run: ./build_integration.sh
env:
Expand All @@ -171,7 +166,6 @@ jobs:
python -m pip install --upgrade pip
python -m pip install tox tox-gh-actions
pip install .
pip install awscli --force-reinstall --upgrade
pip install -r requirements-dev.txt
- name: Test with tox
run: tox
Expand Down
3 changes: 2 additions & 1 deletion kafka/sasl/msk.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@
from kafka.protocol.types import Int32
import kafka.errors as Errors

from botocore.session import Session as BotoSession # importing it in advance is not an option apparently...


def try_authenticate(self, future):
from botocore.session import Session as BotoSession # importing it in advance is not an option apparently...

session = BotoSession()
credentials = session.get_credentials().get_frozen_credentials()
Expand Down
1 change: 0 additions & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,4 @@ Sphinx
sphinx-rtd-theme
tox
xxhash
boto3[crt]
botocore
5 changes: 2 additions & 3 deletions test/test_msk.py
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
import datetime
import json

import pytest

try:
from unittest import mock
except ImportError:
import mock

from kafka.sasl.msk import AwsMskIamClient


@pytest.mark.skip(reason="Not yet supported")
def client_factory(token=None):
from kafka.sasl.msk import AwsMskIamClient

now = datetime.datetime.utcfromtimestamp(1629321911)
with mock.patch('kafka.sasl.msk.datetime') as mock_dt:
Expand Down
1 change: 1 addition & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ deps =
lz4
xxhash
crc32c
botocore
commands =
pytest {posargs:--pylint --pylint-rcfile=pylint.rc --pylint-error-types=EF --cov=kafka --cov-config=.covrc}
setenv =
Expand Down

0 comments on commit 8d61252

Please sign in to comment.