Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add chain_future to send method #143

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: add chain_future to send method #143

wants to merge 2 commits into from

Conversation

wbarnha
Copy link
Owner

@wbarnha wbarnha commented Mar 8, 2024

to fix callback may lost dpkp#2291, and chain_future parameter for kafka producer's send method

This change is Reviewable

wbarnha
wbarnha commented Mar 15, 2024
View reviewed changes
Copy link
Owner Author

@wbarnha wbarnha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On further thought, it would be nice to understand why the original intended callback invocations don't work as-is. I'll need to review the original issue further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbarnha @anexplore