add validate_config function for msk module #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I had issues connecting to our MSK cluster using the kafka-python-ng library and noticed that there was a call to the function
validate_config()
when usingSASL_SSL
, which was not implemented for the MSK module.Similar to the other oauth modules, it is assumed in the conn.py code that there is a function that does the same check that is found in conn.py and added this.
Why
Connection issues to MSK
References
#170 and potentially also @mattoberle's implementation in https://github.com/mattoberle/kafka-python/tree/feature/2232-AWS_MSK_IAM