Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid busy retry #192

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

orange-kao
Copy link

@orange-kao orange-kao commented Aug 9, 2024

Test test/test_consumer_group.py::test_group and test/test_admin_integration.py::test_describe_consumer_group_exists busy-retry and this might have caused Java not having enough CPU time on GitHub runner, and result in test failure.

@orange-kao orange-kao changed the title Avoid busy retry test_consumer_group.py Avoid busy retry Aug 9, 2024
Test test/test_consumer_group.py::test_group and
test/test_admin_integration.py::test_describe_consumer_group_exists
busy-retry and this might have caused Java not having enough CPU time on
GitHub runner, and result in test failure.
@orange-kao orange-kao marked this pull request as ready for review August 9, 2024 06:18
@wbarnha
Copy link
Owner

wbarnha commented Aug 9, 2024

This is pretty funny if this is a valid fix. However, I want to look into this one exception that's causing failure for one test case:

   [2024-08-09 13:12:12,435] ERROR Error while creating ephemeral at /brokers/ids/0, node already exists and owner '72057626408124418' does not match current session '72057626408124421' (kafka.zk.KafkaZkClient$CheckedEphemeral)
  [2024-08-09 13:12:12,440] ERROR [KafkaServer id=0] Fatal error during KafkaServer startup. Prepare to shutdown (kafka.server.KafkaServer)
  org.apache.zookeeper.KeeperException$NodeExistsException: KeeperErrorCode = NodeExists
  	at org.apache.zookeeper.KeeperException.create(KeeperException.java:126)
  	at kafka.zk.KafkaZkClient$CheckedEphemeral.getAfterNodeExists(KafkaZkClient.scala:1821)
  	at kafka.zk.KafkaZkClient$CheckedEphemeral.create(KafkaZkClient.scala:1759)
  	at kafka.zk.KafkaZkClient.checkedEphemeralCreate(KafkaZkClient.scala:1726)
  	at kafka.zk.KafkaZkClient.registerBroker(KafkaZkClient.scala:95)
  	at kafka.server.KafkaServer.startup(KafkaServer.scala:293)
  	at kafka.server.KafkaServerStartable.startup(KafkaServerStartable.scala:44)
  	at kafka.Kafka$.main(Kafka.scala:82)
  	at kafka.Kafka.main(Kafka.scala)

Copy link
Owner

@wbarnha wbarnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's pretty funny, looks like it abated the issue.

@wbarnha wbarnha merged commit 31a6b92 into wbarnha:master Aug 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants