Possibly clean up the receive code #197
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curtiscook
commented
Aug 23, 2024
| break | ||
| else: | ||
| try: | ||
| # BlockingIOError is a PY2 catchall that should not be caught |
There was a problem hiding this comment.
BlockingIOError was actually not getting reraised before, so I'm unsure if this is actually the correct intended behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing sockets are getting double logged at an error level due to #139, so thought I'd try to clean this code up a little bit by getting rid of the breaks, noops, and using exceptions as control flow