Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py37 to tox.ini #79

Closed
wants to merge 6 commits into from
Closed

Conversation

hairychris
Copy link

No description provided.

@hairychris
Copy link
Author

hairychris commented Jul 14, 2018

Blocked by travis-ci/travis-ci#9815 as Travis doesn't currently support Python 3.7 and 3.4 simultaneously.

@carver
Copy link

carver commented Jul 16, 2018

From the travis issue:

So for now the best thing to do is to have sudo: required just for job with 3.7.0.

Maybe this workaround could get us there without waiting ^ ?

This will make the tests run on Trusty with Sudo active, it is
unknown what other effects this will have on the project.

Please revert this commit when Travis fix their issue.
@wbolster
Copy link
Owner

this is not blocking anything. plyvel works with python 3.7 already, and you can pip install it already today. the only thing missing is linux wheels for 3.7

@hairychris
Copy link
Author

Sorry I presumed making sure the build works was a requirement to getting these wheels released.

@carver
Copy link

carver commented Jul 16, 2018

this is not blocking anything ... the only thing missing is linux wheels for 3.7

Cool, is there anything blocking the release of the linux wheels?


@hairychris The Travis thread implies that dist: xenial might also be required

@wbolster
Copy link
Owner

wbolster commented Jul 16, 2018

no blockers anymore except some maintainer time and effort. :)

i tried to update libsnappy (embedded in the wheels) to the latest upstream release but ran into some complications... the build system changed to cmake which just requires a few different commands, but cmake is not available by default inside the build environment (docker container).

i fixed all of the above already, and just need to find a bit of time to round it up, make new builds and publish those on pypi.

feel free to kindly remind me in a few days if i haven't gotten around to it by then.

@carver
Copy link

carver commented Jul 16, 2018

Thanks wbolster!

@hairychris ah, and now 3.4 is busted, which people in that thread experienced too. That's why the final line was (my emphasis):

So for now the best thing to do is to have sudo: required just for job with 3.7.0.

@hairychris
Copy link
Author

Yeah I thought that might happen but worth checking, I don't really want to change too much to get around a temporary issue.

@wbolster
Copy link
Owner

i published plyvel 1.0.5 with python 3.7 wheels on pypi. https://plyvel.readthedocs.io/en/latest/news.html

@wbolster
Copy link
Owner

i pushed the tox.ini changes in fbfaecd

let's wait for travis to settle before introducing hacks that will quickly turn into technical debt when travis sorts out their infra.

@wbolster
Copy link
Owner

for those interested: 20d1d2c contains the build changes i referred to earlier

@wbolster
Copy link
Owner

wbolster commented May 3, 2019

closing, see #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants