Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RFC3779 X509 extensions for IPs and AS-IDs #245

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

niklbird
Copy link

No description provided.

@wbond
Copy link
Owner

wbond commented Nov 11, 2022

Looks like you need to fix some linting errors

@niklbird
Copy link
Author

Looks like you need to fix some linting errors

Thank you! I fixed them now :)

@niklbird
Copy link
Author

niklbird commented Dec 6, 2022

Hey :) Is there anything still missing that you need?

@wbond
Copy link
Owner

wbond commented Aug 23, 2023

Could you rebase this on master?

@wbond
Copy link
Owner

wbond commented Aug 23, 2023

Thanks for taking the time to add these.

Overall it looks good. The one style change I would request is that for this project we use under_score notation instead of camelCase for the ASN.1 field names. In other words, things like addressRange should be address_range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants