Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location / name of Solarized has changed #710

Merged
merged 1 commit into from
Oct 31, 2012
Merged

Conversation

Iristyle
Copy link
Contributor

Update package to use repository https://github.com/SublimeColors/Solarized

There were a number of lingering pull requests on the Textmate repo managed by @deplorableword specific to Sublime.
https://github.com/deplorableword/textmate-solarized/

There has been some apparent inconsistencies with how Textmate is rendering colors which is making accepting these pulls an issue, when it comes to supporting colors correctly on both Sublime and Textmate. For instance
deplorableword/textmate-solarized#33

Furthermore, there are Sublime specific colors that are useful to assign to plugins that render.

So @braver and I decided to start an organization and fork the code over to a new repository for Sublime specific adjustments.

Thanks!

@wbond
Copy link
Owner

wbond commented Oct 23, 2012

You may want your org to be called SublimeColorSchemes since this is a color scheme and not a theme.

@wbond
Copy link
Owner

wbond commented Oct 23, 2012

@deplorableword Are you ok with your package being replaced by the version from this organization?

@deplorableword
Copy link

Yep, if those guys are happy that the colours better match for sublime then fire away.

On 23 Oct 2012, at 05:01 AM, Will Bond [email protected] wrote:

@deplorableword Are you ok with your package being replaced by the version from this organization?


Reply to this email directly or view it on GitHub.

@braver
Copy link
Collaborator

braver commented Oct 23, 2012

Re: the name. The files are called filename.tmTheme... potatoes, potatoes ;). You're right of course, I don't mind changing it (SublimeColors perhaps?). @Iristyle?

@wbond
Copy link
Owner

wbond commented Oct 23, 2012

Well, they are just called .tmTheme files to be compatible with Textmate theme files. Themes in Sublime Text actually change the whole chrome of the editor, whereas color schemes just change the color of the text in the editor pane. I only suggested it to try and make it less confusing for users, it certainly is not necessary.

You probably have seen it before, but here's a ST theme: https://github.com/buymeasoda/soda-theme

@braver
Copy link
Collaborator

braver commented Oct 24, 2012

@wbond @Iristyle completed the rename, the new repo for inclusion is at https://github.com/SublimeColors/Solarized

@sentience
Copy link
Collaborator

@Iristyle Please update this pull request (or close it and open a new one) with the updated repo address per @braver’s comment so that this can be merged.

@Iristyle
Copy link
Contributor Author

Whoops.. missed the notifications somehow.

Pull updated..

@@ -153,7 +153,7 @@
"https://github.com/dbousamra/sublime-rst-completion",
"https://github.com/dbp/sublime-rust",
"https://github.com/demon386/SmartMarkdown",
"https://github.com/deplorableword/textmate-solarized",
"https://github.com/SublimeColors/Solarized",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this line to maintain alphabetical order.

Update package to use repository SublimeColors/Solarized
sentience added a commit that referenced this pull request Oct 31, 2012
# By Ethan J. Brown
# Via Iristyle
* Iristyle/patch-2:
  Location / name of Solarized has changed

Conflicts:
	repositories.json
@sentience sentience merged commit 9b4abad into wbond:master Oct 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants