-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location / name of Solarized has changed #710
Conversation
You may want your org to be called SublimeColorSchemes since this is a color scheme and not a theme. |
@deplorableword Are you ok with your package being replaced by the version from this organization? |
Yep, if those guys are happy that the colours better match for sublime then fire away. On 23 Oct 2012, at 05:01 AM, Will Bond [email protected] wrote:
|
Re: the name. The files are called filename.tmTheme... potatoes, potatoes ;). You're right of course, I don't mind changing it (SublimeColors perhaps?). @Iristyle? |
Well, they are just called .tmTheme files to be compatible with Textmate theme files. Themes in Sublime Text actually change the whole chrome of the editor, whereas color schemes just change the color of the text in the editor pane. I only suggested it to try and make it less confusing for users, it certainly is not necessary. You probably have seen it before, but here's a ST theme: https://github.com/buymeasoda/soda-theme |
@wbond @Iristyle completed the rename, the new repo for inclusion is at https://github.com/SublimeColors/Solarized |
Whoops.. missed the notifications somehow. Pull updated.. |
@@ -153,7 +153,7 @@ | |||
"https://github.com/dbousamra/sublime-rst-completion", | |||
"https://github.com/dbp/sublime-rust", | |||
"https://github.com/demon386/SmartMarkdown", | |||
"https://github.com/deplorableword/textmate-solarized", | |||
"https://github.com/SublimeColors/Solarized", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this line to maintain alphabetical order.
Update package to use repository SublimeColors/Solarized
# By Ethan J. Brown # Via Iristyle * Iristyle/patch-2: Location / name of Solarized has changed Conflicts: repositories.json
Update package to use repository https://github.com/SublimeColors/Solarized
There were a number of lingering pull requests on the Textmate repo managed by @deplorableword specific to Sublime.
https://github.com/deplorableword/textmate-solarized/
There has been some apparent inconsistencies with how Textmate is rendering colors which is making accepting these pulls an issue, when it comes to supporting colors correctly on both Sublime and Textmate. For instance
deplorableword/textmate-solarized#33
Furthermore, there are Sublime specific colors that are useful to assign to plugins that render.
So @braver and I decided to start an organization and fork the code over to a new repository for Sublime specific adjustments.
Thanks!