Skip to content

Commit

Permalink
Pass correct names for snapshot indices while updating remote store i…
Browse files Browse the repository at this point in the history
…ndex settings (opensearch-project#13529)

Signed-off-by: Lakshya Taragi <[email protected]>
  • Loading branch information
ltaragi authored and wangdongyu.danny committed Aug 22, 2024
1 parent a88f9ed commit f85dc07
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ private Settings getOverrideSettingsInternal() {
clusterService.state(),
clusterSettings,
clusterService.getSettings(),
request.getDescription()
String.join(",", request.indices())
);
return settingsBuilder.build();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1594,7 +1594,7 @@ public void testNewIndexIsRemoteStoreBackedForRemoteStoreDirectionAndMixedMode()

ClusterSettings clusterSettings = new ClusterSettings(Settings.EMPTY, ClusterSettings.BUILT_IN_CLUSTER_SETTINGS);

request = new CreateIndexClusterStateUpdateRequest("create index", "test", "test");
request = new CreateIndexClusterStateUpdateRequest("create index", "test-index", "test-index");

Settings indexSettings = aggregateIndexSettings(
clusterState,
Expand Down Expand Up @@ -1675,7 +1675,7 @@ public void testNewIndexIsRemoteStoreBackedForRemoteStoreDirectionAndMixedMode()
finalClusterSettings
);
});

assertEquals(error.getMessage(), "failed to create index [test-index]");
assertThat(
error.getCause().getMessage(),
containsString("Cluster is migrating to remote store but no remote node found, failing index creation")
Expand Down

0 comments on commit f85dc07

Please sign in to comment.