Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑 Duplicate sub tasks when project is duplicated #499

Conversation

haideralibd
Copy link
Contributor

@haideralibd haideralibd commented Aug 2, 2024

Summary by CodeRabbit

  • New Features
    • Introduced enhanced task management capabilities with new methods for querying subtasks and managing boardable entities related to subtasks.
    • Improved hierarchical task relationships for better organization and retrieval of tasks and subtasks.

Copy link

coderabbitai bot commented Aug 2, 2024

Walkthrough

The recent updates to the Task model enhance task management by introducing two new public methods. The scopeSubTasks($query) method allows for efficient querying of subtasks through a hierarchical relationship, while the sub_boardables() method establishes a connection to subtasks categorized as boardable entities. Together, these additions improve the model's functionality, making it easier to manage parent-child task structures and their associated boardable items.

Changes

File Change Summary
src/Task/Models/Task.php Added scopeSubTasks($query) for querying subtasks and sub_boardables() for retrieving boardable subtasks.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TaskModel
    participant SubTask

    User->>TaskModel: Request subtasks
    TaskModel->>SubTask: scopeSubTasks() to fetch subtasks
    SubTask-->>TaskModel: Return list of subtasks
    TaskModel->>User: Provide subtasks
Loading

🐰🌼
In the task garden, new paths do bloom,
Subtasks and boardables make room.
With a hop and a skip, we manage with glee,
A model that's bright, as bright as can be!
Hooray for the changes, let’s all celebrate,
For tasks and their subtasks, oh, isn’t it great? 🌼🐰


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 12d53ca and 4e83d08.

Files ignored due to path filters (1)
  • views/assets/vendor/vue-fullscreen/vue-fullscreen.min.js is excluded by !**/*.min.js
Files selected for processing (1)
  • src/Task/Models/Task.php (2 hunks)
Additional comments not posted (2)
src/Task/Models/Task.php (2)

91-93: LGTM! Ensure the relationship is used correctly.

The sub_boardables method correctly defines a hasMany relationship for boardable entities categorized as subtasks. Ensure that this relationship is used correctly in the rest of the codebase.


78-80: Ensure the scope method is used correctly.

The scopeSubTasks method correctly filters tasks by parent_id. However, ensure that this method is used in the context of a query builder and that $this->id is correctly set when the method is called.

@haideralibd haideralibd force-pushed the feat/project-subtask-duplicate branch from 079c32d to 4e83d08 Compare October 8, 2024 06:27
@Rubaiyat-E-Mohammad Rubaiyat-E-Mohammad added QA Approved This PR is approved by the QA team Ready to Merge This PR is now ready to be merged labels Oct 8, 2024
@aminurislamarnob aminurislamarnob merged commit 4022e78 into weDevsOfficial:develop Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Approved This PR is approved by the QA team Ready to Merge This PR is now ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants