-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚑 Duplicate sub tasks when project is duplicated #499
🚑 Duplicate sub tasks when project is duplicated #499
Conversation
WalkthroughThe recent updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TaskModel
participant SubTask
User->>TaskModel: Request subtasks
TaskModel->>SubTask: scopeSubTasks() to fetch subtasks
SubTask-->>TaskModel: Return list of subtasks
TaskModel->>User: Provide subtasks
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
views/assets/vendor/vue-fullscreen/vue-fullscreen.min.js
is excluded by!**/*.min.js
Files selected for processing (1)
- src/Task/Models/Task.php (2 hunks)
Additional comments not posted (2)
src/Task/Models/Task.php (2)
91-93
: LGTM! Ensure the relationship is used correctly.The
sub_boardables
method correctly defines ahasMany
relationship for boardable entities categorized as subtasks. Ensure that this relationship is used correctly in the rest of the codebase.
78-80
: Ensure the scope method is used correctly.The
scopeSubTasks
method correctly filters tasks byparent_id
. However, ensure that this method is used in the context of a query builder and that$this->id
is correctly set when the method is called.
079c32d
to
4e83d08
Compare
Summary by CodeRabbit