Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-Paths not working with OAuth2 #4016

Closed
steigr opened this issue Sep 15, 2023 · 2 comments · Fixed by #4022
Closed

Sub-Paths not working with OAuth2 #4016

steigr opened this issue Sep 15, 2023 · 2 comments · Fixed by #4022
Assignees
Labels
bug Something isn't working team/pesto

Comments

@steigr
Copy link

steigr commented Sep 15, 2023

Describe the bug

In #3992 sub-path support for the UI has been introduced.

If I configure wego with oauth2 authentication I get redirected (e.g. from /wego sub-path) to /oauth2 and not $subpath/oauth2.

Environment

  • Weave-Gitops Version : v0.32.0
  • Flux Version: /n/a
  • Kubernetes version: n/a

To Reproduce
Steps to reproduce the behavior:

  1. Set up wego with OAuth2.
  2. Configure OAuth2 / OIDC provider. ( via oidc-auth secret from helm chart).
  3. Set clientID/clientSecret/issuerURL.
  4. Set callbackURL to $wegoBaseUrl + "/oauth2/callback" ( e.g. https://example.com/wego/oauth2/callback )
  5. Open the UI.
  6. Click on "Login with OIDC Provider".

Expected behavior

After clicking the "Login with OIDC Provider" button there should be a redirect to the provider and after successful authentication the callback should provide wego the required information (thus forwarding after login to the "real" UI).

Actual Behavior

  1. Nothing (HTTP/404).
  2. After adding the path /oauth2 to the ingress I just get redirected back to the login screen.

Additional Context (screenshots, logs, etc)

I think, as #3992 covered the path-prefix for the UI only, OAuth2 should made aware of the prefix as well.

@steigr steigr added the bug Something isn't working label Sep 15, 2023
@bigkevmcd
Copy link
Contributor

@steigr Thanks for this, we'll get it fixed.

@bigkevmcd
Copy link
Contributor

@steigr thanks again, this should be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working team/pesto
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants