Fix the OIDC login button when using a RoutePrefix. #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigkevmcd
force-pushed
the
oidc-sub-path
branch
2 times, most recently
from
231cc8f
to
a68b109
Compare
foot
reviewed
Sep 19, 2023
| @@ -92,7 +92,7 @@ function SignIn({ darkModeEnabled = true }: Props) { | |||
|
|
|||
| const handleOIDCSubmit = () => { | |||
| const CURRENT_URL = window.origin; | |||
| return (window.location.href = `/oauth2?return_url=${encodeURIComponent( | |||
| return (window.location.href = `./oauth2?return_url=${encodeURIComponent( | |||
There was a problem hiding this comment.
This seems to work. Which makes sense, but I thought I read something to the contrary recently -- that while a, img, script etc tags respect base tags, the JS world (e.g. setting location.href) does not.
However after doing some more testing it seems that it does, and this works fine, even if you end up at localhost:9001/wego/signin/ (with a trailing slash), which still routes correctly, and then logs into OIDC correctly too..
There was a problem hiding this comment.
JSDOM etc at least don't support navigation so this is a trickier case to test w/out more involved acceptance tests..
foot
reviewed
Sep 19, 2023
Make the OIDC login button relative so that it uses the route Prefix from the base.
bigkevmcd
force-pushed
the
oidc-sub-path
branch
from
1552dda
to
809c7e3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4016
What changed?
Make the OIDC login button relative so that it uses the route prefix from the HTML base element.
Why was this change made?
To address a bug when logging in with OIDC and a Route Prefix.
How was this change implemented?
Tests.
How did you validate the change?
Setup a login via Dex and it now goes to the correct URL.
Release notes
Allow use of the route prefix mechanism with OIDC authentication.
Documentation Changes