increase coverage on integration tests #120
Conversation
|
Looks like its trying to get coverage from the fakes: https://coveralls.io/builds/39429875/source?filename=pkg%2Ffluxops%2Ffluxopsfakes%2Ffake_flux_handler.go I've seen there is a ignore option in |
|
@luizbafilho go-acc can use any flags from go test. I have it set to test every go file in the dir. I should add something to skip those though. Good catch. |
test/acceptance/test/utils_test.go
Outdated
| ) | ||
|
|
||
| func TestFileExists(t *testing.T) { | ||
| require.True(t, FileExists("utils.go")) |
There was a problem hiding this comment.
kind suggestion. It would be great to have a file used specifically for this test. In case the rare case utils.go changes name. There are some methods to create temp files like this:
tempFile, err := ioutil.TempFile("", "")
os.Remove(tempFile.Name())
Then we don't need to rely any external resources to test this function 🙂
There was a problem hiding this comment.
that is a very valid point
I looked it over and this looks like it is accurate on its coverage.