Scan depends on publish #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Thompson12
approved these changes
Mar 25, 2021
J-Thompson12
added a commit
that referenced
this pull request
Mar 25, 2021
* fix docker push * fix docker image push * change docker username/pass * fix scan docker user/pass * change login order * add context * Run scan only when image has been published * use cmd line * login cmd * Scan depends on publish (#22) * Only run when publish completes * testing with docker hub username env var * Revert "testing with docker hub username env var" This reverts commit 277ae45. * new repo name * Using testing image temporarily * remove pr run * add makefile * conflicts Co-authored-by: Justin thompson <[email protected]> Co-authored-by: Jose C Ordaz <[email protected]>
josecordaz
added a commit
that referenced
this pull request
Mar 30, 2021
* fix docker push * fix docker image push * change docker username/pass * fix scan docker user/pass * change login order * add context * Run scan only when image has been published * use cmd line * login cmd * Scan depends on publish (#22) * Only run when publish completes * testing with docker hub username env var * Revert "testing with docker hub username env var" This reverts commit 277ae45. * new repo name * Using testing image temporarily * Attempt to trigger the job by removing branches from workflow_run * Added type requested * Added if to Snyk job * Switch to try with a label * Fixed trigger label * Scan inside publish workflow * Renamed deploy to deploy_scan * Trigger deploy_scan job for PullRequests * Uncomment FOSSA(using free license for testing). Separate deploy workflow into two parts. One for Only the deployment in s3 and the other one for docker publishing and scan. * Removed pull_requests from deploy workflow Co-authored-by: Justin thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.