Add version check on every command #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Thompson12
force-pushed
the
189-wego-version
branch
from
df29675
to
d0df50b
Compare
josecordaz
reviewed
Jun 1, 2021
J-Thompson12
force-pushed
the
189-wego-version
branch
from
58b9cff
to
9880ba2
Compare
J-Thompson12
force-pushed
the
189-wego-version
branch
from
b41edf8
to
abc0656
Compare
josecordaz
approved these changes
Jun 2, 2021
cmd/wego/version/cmd.go
Outdated
| } | ||
|
|
||
| if err == nil && checkResponse.Outdated { |
There was a problem hiding this comment.
Not need to check err==nil here as it is inferred for the previous if statement.
There was a problem hiding this comment.
Whoops forgot about that after changing things up. Good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a version check that runs after every command and adds flux version to version command. https://app.zenhub.com/workspaces/weaveworks-foss-603cb6b1d4dff9000e242dc4/issues/weaveworks/weave-gitops/189