add bin check #24
Merged
add bin check #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecordaz
reviewed
Mar 26, 2021
josecordaz
reviewed
Mar 30, 2021
| ) | ||
|
|
||
| // The current wego version | ||
| var Version = "v0.0.0" |
There was a problem hiding this comment.
I would rather prefer to have this dynamic. You can do something like this https://github.com/weaveworks/wksctl/pull/331/files#diff-9099d16d1f5039d08a9c52239830f5355aa0ad958d4f8f18bd5457581acbf546R354
There was a problem hiding this comment.
@J-Thompson12 I just saw that you had this already. I wonder why we did change it
There was a problem hiding this comment.
So we had a conversation at standup yesterday and we need to use checkpoint because it does metrics as well as the version check
josecordaz
approved these changes
Mar 31, 2021
added 2 commits
April 1, 2021 08:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://weaveworks.atlassian.net/browse/WKP-1916