-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resources health checks #3590
Resources health checks #3590
Conversation
Front end looks okay but I can't test yet as OSS main appears to broken right now |
@joshri can you take another look now? |
What’s the difference between health check and what we do for status? I’m mainly asking bc the front end code ends up looking very similar to what we use for the status indicator, and I’m wondering if it can be reused - at least the JSX should wind up the same to reuse styles. Also - using the full message makes the column realllllly wide in the table. Is it correctly prioritized over status and message? Just expressing my overall desire to get rid of the horizontal scrolling Are there plans to add this info to the detail pages? Or is this something that exists on non-primitives only? |
It is a replacement. Those are gonna be the source of truth for resource health. Regarding the details page, I think the idea is to have an aggregator icon that would "consolidate" the whole app status, if all items in the inventory is green, there is a green icon on the top, and so on. |
[UI]
|
Okay no worries - just trying to get some context as to what's going on. I was able to see the column and indicator for a Deployment in the UI, so consider the front end approved 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I particularly liked how we go about testing this 👍
--------- Co-authored-by: TheGostKasper <[email protected]>
Closes #2596
What changed?
Why was this change made?
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes