Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verified sources #3887

Merged
merged 8 commits into from
Aug 1, 2023
Merged

Verified sources #3887

merged 8 commits into from
Aug 1, 2023

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Jul 26, 2023

Closes #3790

What changed?

  • "verified" icon shown beside Source controller resources which have the SourceVerified condition.
  • "verified" icon shown beside HelmRelease and Kustomization resources which reference a verified Source.
  • condition message is shown on hover over icon.

Why was this change made?
We want to know if Sources and the things that are deployed from those Sources are "trusted".

How was this change implemented?
Added verified column in Applications and Sources tables.

How did you validate the change?

  • Added shipping-service-podinfo (verified git repo) and podinfo-oci (verified oci repo) on demo-01
Screenshot 2023-07-27 at 15 32 09

Also, in Applications, the podinfo kustomization references podinfo-oci added above:

Screenshot 2023-07-27 at 15 33 51

Documentation Changes
Docs to be updated explaining the feature (including the fact that if you don’t set up for verification it will be blank)

@AlinaGoaga AlinaGoaga added the type/enhancement New feature or request label Jul 26, 2023
@AlinaGoaga AlinaGoaga marked this pull request as ready for review July 27, 2023 15:09
Copy link
Contributor

@joshri joshri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ui/lib/objects.ts Show resolved Hide resolved
@AlinaGoaga AlinaGoaga merged commit 63207e9 into main Aug 1, 2023
13 checks passed
@AlinaGoaga AlinaGoaga deleted the verified-sources branch August 1, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Show verified Sources
3 participants