-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flex with breakpoint prop #3953
Conversation
I think we don't need to add the breakpoint as we can make use of the
redirect3-2023-08-18_13.23.27.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the creatrivity, but I would also like to see if @TheGostKasper 's suggestion would work here if possible.
ui/components/Flex.tsx
Outdated
@@ -59,4 +59,10 @@ class Flex extends React.PureComponent<Props> { | |||
} | |||
} | |||
|
|||
export const ColumnOnBreakpoint = styled(Styled(Flex))<{ breakpoint: number }>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dig this 👍
b740e20
to
116b994
Compare
Flex gap controls space in between, you can adjust the right gap. and by adding This record without setting a gap value. |
@TheGostKasper Any ideas on why the wrap prop isn't working in my code in the right half of my screenshot? |
I believe it's because there's no overlap in width as the Flex Row still show both div without any problems. |
But the div on the right is clearly off the screen? What am I missing? |
116b994
to
c2cd13d
Compare
There was an important diff between EE and OSS here - OSS added a special component for the sync and suspend buttons a couple weeks ago that is now set to 50% width by default, allowing for the large info flex to now wrap when it runs up against it. Thanks @TheGostKasper for testing |
Closes: #2907
Creates styled component extension of Flex with a breakpoint prop to swap
flex-direction
when below a certain screen widthlaggy video here:
resposive-large-info.mov