Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard helmrepository apiVersion should be v1beta2 not v1 #3959

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

enekofb
Copy link
Contributor

@enekofb enekofb commented Aug 22, 2023

Closes #3957

What changed?

Changes generated dashboard helmrepository apiVersion from v1 to v1beta2

Why was this change made?

HelmRepository still not yet in v1 so creating in v1 will end in the resource not been created

How did you validate the change?

  • Adjusted unit test expectation
  • Executed the command too

Release notes
No

Documentation Changes
No

Copy link
Contributor

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Member

@chanwit chanwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @enekofb
LGTM

@enekofb enekofb merged commit 9808968 into main Aug 22, 2023
24 checks passed
@enekofb enekofb deleted the issues/3957 branch August 22, 2023 09:04
This was referenced Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitOps create dashboard export error
3 participants