-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helm 'values' flags to create dashboard #3990
Add helm 'values' flags to create dashboard #3990
Conversation
Hi, sorry i drop this PR from nowhere. I was playing with the |
6b79eb4
to
5c82a07
Compare
@laupse thank you for sending this PR, the new CLI flag is a useful addition 👍 I took the liberty of editing your PR slightly and I have now asked for another review. But I think it should be good to merge soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Add helm 'values' flags to create dashboard weaveworks#2
fbdafe7
to
80c8a10
Compare
Thank you for taking time considering and merging this PR 😄 |
What changed?
flags
--values
added tocreate dashboard
andbeta run
so we can provide additional helm values when generating HelmRelease from thegitops
cliWhy was this change made?
Didn't wanted to have to deal with editing the yaml HelmRelease file to add values
How was this change implemented?
This is has been inspired by how it is implemented in flux for creating HelmRelease
How did you validate the change?
with this yaml
we have this export from the below command
Release notes
N/A
Documentation Changes
cli is self documented