-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Artifact Metadata section to OCI Repository detail pages #4002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 No blockers, just nits.
ui/components/Metadata.tsx
Outdated
|
||
const MetadataSection: React.FC<{ title: string; items: [string, any][] }> = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is any
type really valid here? If I pass in { foo: { bar: 'baz' }}
, will the component render OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was any
bc we're turning some of the values into links - I can change it into string | JSX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of accuracy, I like string | JSX
. That way the next person has an idea of what they can pass in.
@joshri fyi weaveworks/weave-gitops-enterprise#3341 (comment) Maybe we should just show all annotations as key value pairs, while giving precedence to the pre-defined ones (that start with |
5ae95c9
to
ab4cace
Compare
Closes: weaveworks/weave-gitops-enterprise#3341
Adds a new section to the Metadata component for OCI Repositories for clarity - we were previously displaying revision and source in the info list, but folks were expecting to see it in Metadata (which only recognizes our metadata.weaveworks prefix).