-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App page secrets error #4021
App page secrets error #4021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean up too!
…gitops into app-page-secrets-error
Lets try adding a little message to the UI too, some little admonition like..
|
…gitops into app-page-secrets-error
…gitops into app-page-secrets-error
Hi @mmoulian, we're got an info alert in this PR. I can't seem to be able to find something similar in the designs. Would you mind having a look at the styles and let me know which colors you'd prefer / add it to Figma? Below is how it looks atm. Thank you |
Hi @AlinaGoaga! Searching through our archive files I found this solution. We did it for alerts and errors, but I'm not sure if the alert in PR is the same type or needs a distinction. This solution is applied in our Demo on a page like this: Let me know if it help you! |
Thanks @mmoulian, yup I know these ones, we need one in blue for the info box please (light and dark) |
@AlinaGoaga I made the design here. ..It is very similar to your proposal. You can see it in dark or light mode (see movie). https://github.com/weaveworks/weave-gitops/assets/95616291/36d928a5-9d94-4b3e-8c4d-9c57ac8056c3 Note.PR.mov |
Thanks @mmoulian, will open a small PR separately to adjust the style :) |
{automation.type === "HelmRelease" && | ||
(automation as HelmRelease).kubeConfig === "" ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that this change caused that only HelmRelease type can have detail now as reported in this bug.
Closes #3843
What changed?
For helm releases, do not try and read secret if
spec.kubeConfig
has been set.Why was this change made?
On the Applications Page, users would get several errors related to the secret not being present.
get helmrelease inventory: secrets "sh.helm.release.v1.grafana-agent-logs.v7" not found
.This is not relevant for cases in which
kubeConfig
is used.