Fix 'cluster not found' error when requesting source from automation sourceRef
#4028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed source object request and new tab on new docs button
joshri
force-pushed
the
verified-cluster-name
branch
from
b1eb0ea
to
344e1d1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4019
The request for an automation's source was using the
sourceReffield, which doesn't have a namespace if the source is in the same one as an automation, and NEVER has a cluster name. This PR uses the automation's namespace and cluster name to actually get the source back on these requests.Also fixes not actually opening a new tab on the new docs button - careful when using the
asprop for styles with a styled component, because it actually changed theaelement into a button as well