Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves skipped backporting between versions 0.29.0 and 0.30.0 #4037

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

LappleApple
Copy link
Contributor

What changed?

Takes care of backporting that got postponed due to some PR review backup and forgetfulness a few weeks back.

Why was this change made?

This is to fulfill a required, standard docs revision step and to restore continuity between past docs versions.

How was this change implemented?

Updated page names from Pipelines, GitOpsSets, and GitOps Run to match between the two versions; adjusted the 0.29.0 sidebar to match 0.30.0's, and repaired broken links.

How did you validate the change?

I ran yarn start and npm run build a few times.

Documentation Changes

It's a docs change.

@LappleApple LappleApple added documentation Improvements or additions to documentation user-guide Improvements to docs at https://docs.gitops.weave.works/ labels Sep 21, 2023
Copy link
Contributor

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morancj
Copy link
Member

morancj commented Sep 21, 2023

Looks like a few renames still present, not sure if this is deliberate, e.g.

$ git diff --compact-summary docs-fix-sept21..9c1268a -- website
…
website/versioned_docs/version-0.29.0/pipelines/{pipelines-templates.mdx => pipeline-templates.mdx}
…

I have not tried a local build to test.

@LappleApple LappleApple merged commit 388acf4 into main Sep 21, 2023
18 checks passed
@LappleApple LappleApple deleted the docs-fix-sept21 branch September 21, 2023 10:19
@morancj
Copy link
Member

morancj commented Sep 21, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation user-guide Improvements to docs at https://docs.gitops.weave.works/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants