Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

override default tabs min-width at (600px) media query #4071

Merged
merged 2 commits into from
Oct 9, 2023
Merged

override default tabs min-width at (600px) media query #4071

merged 2 commits into from
Oct 9, 2023

Conversation

ahussein3
Copy link
Contributor

Closes #3392

What changed?

  • update the tab min-width to be auto and update the size on larger screen size.

Why was this change made?

  • This change made to make the tabs component being usable on smaller screen size.

How did you validate the change?

  • Tested locally

@ahussein3 ahussein3 added the area/ui Issues that require front-end work label Oct 9, 2023
@ahussein3 ahussein3 self-assigned this Oct 9, 2023
@ahussein3
Copy link
Contributor Author

ahussein3 commented Oct 9, 2023 •
edited
Loading

Both screen shots at 1024px width view.

Before:
image

After:
image

@ahussein3 ahussein3 changed the title override default tabs min-width at media query override default tabs min-width at (600px) media query Oct 9, 2023
@ahussein3 ahussein3 merged commit 43c7d9f into main Oct 9, 2023
17 checks passed
@ahussein3 ahussein3 deleted the ReduceTabsWidthToFitLargeScreen branch October 9, 2023 18:53
@weave-gitops-bot weave-gitops-bot mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpellizzari jpellizzari jpellizzari approved these changes

@foot foot Awaiting requested review from foot

Assignees

@ahussein3 ahussein3

Labels
area/ui Issues that require front-end work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahussein3 @jpellizzari