Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gitops-ee bootstrap cli user documentation #4073

Merged
merged 11 commits into from
Nov 8, 2023
Merged

Conversation

waleedhammam
Copy link
Contributor

Closes weaveworks/weave-gitops-enterprise#3406

Documentation Changes

  • add gitops-ee bootstrap cli user documentation

@waleedhammam waleedhammam added the documentation Improvements or additions to documentation label Oct 10, 2023
Copy link
Contributor

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks waleed for taking the time to get the conversation started. some suggestions added.

import TierLabel from "../../_components/TierLabel";

# Install Weave GitOps Enterprise via CLI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we want to manage user expectations coming to the page they better decide whether they could
take advantage of the CLI vs other installation mechanisms, we should frame the persona and scenario that currently the cli is designed and the value it gets. Alternatively, to point the user to the default install method.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@enekofb enekofb Nov 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added #4121

toc_max_heading_level: 4
---

import TierLabel from "../../_components/TierLabel";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could add some notes about maturity alpha and security considerations: do we consider mature and secure enough for running it against your production environment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do some assessment in terms of security risks


The bootstrap wizard will take you step-by-step into configuring Weave GitOps Enterprise. To understand more about the CLI configurations experience, check the below sections [here](#cli-configurations).

## Understanding `gitops-ee bootstrap`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are the expectations for a platform engineer around this section?


## Appendix

### CLI configurations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we expect to maintain/update the documentation, if there is an overhead or manual, it might get quickly outdated

Copy link
Contributor

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions in the pr:

  • reflect modes: interactive and non-interactive
  • expand on the ssh access in particular the keys. they could go to the wizard
  • cluster user instead of admin credentials to be consistent with existing documentation https://docs.gitops.weave.works/docs/enterprise/getting-started/install-enterprise/#securing-access-to-the-dashboard
  • review the stages are up to date
  • review the wording on the domain stage
  • review external DNS, should not be part of bootstrapping. we dont manage dns.
  • add some picture or screenshot so it is not so much text
  • to sync: what is the goal of the steps section and whether is the best alternative, for example, if the cli is sefl-contained, why not just leverage to that instead of having it there in other ones
  • cli configuration how would be maintained?

Added suggestions here #4115

* reviewed heading and pre-requirements

* added initial review

* refactoring dashboard access

* ready for a second review

* added externalDNS link
@enekofb enekofb self-requested a review November 2, 2023 15:58
Copy link
Contributor

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second pr with suggestions https://github.com/weaveworks/weave-gitops/tree/add-cli-docs-eneko2
and the questions that still open from the previous review

enekofb and others added 3 commits November 6, 2023 08:36
* added persona and outcome

* might be redundant

* basic setup

* basic setup

* small fix for link
Copy link
Contributor

@MostafaMegahid MostafaMegahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs look good to me.

@waleedhammam waleedhammam merged commit 1aec45c into main Nov 8, 2023
20 checks passed
@waleedhammam waleedhammam deleted the add-cli-docs branch November 8, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phase1 CLI: Streamline onboarding journey. Complete if pre-requirements are met.
3 participants