Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove GitOps Run CLI commands #4111

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix: Remove GitOps Run CLI commands #4111

merged 2 commits into from
Oct 31, 2023

Conversation

yiannistri
Copy link
Contributor

Part of #weaveworks/weave-gitops-enterprise#3514

What changed?
Updated the gitops CLI to remove GitOps Run commands.

Why was this change made?
Because we are deprecating this feature.

How was this change implemented?
By deleting the Go files that included GitOps Run-related commands.

How did you validate the change?

make
./bin/gitops --help 

Release notes
TBD

Documentation Changes
We have updated docs already.

Comment on lines +20 to +23
"github.com/weaveworks/weave-gitops/cmd/gitops/replan"
"github.com/weaveworks/weave-gitops/cmd/gitops/resume"
"github.com/weaveworks/weave-gitops/cmd/gitops/set"
"github.com/weaveworks/weave-gitops/cmd/gitops/suspend"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep these still? As I see it removes only beta, remove, and run.

If we want to keep replan, resume, suspend, etc, do we want to delete remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for deleting remove is because the only command there was used to remove GitOps Run sessions. replan, resume and suspend commands are interacting with Terraform resources which is why I kept them.

@yiannistri yiannistri enabled auto-merge (rebase) October 31, 2023 15:28
@yiannistri yiannistri merged commit 66aecca into main Oct 31, 2023
21 checks passed
@yiannistri yiannistri deleted the remove-gitops-run-cli branch October 31, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants