Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make target to download binaries dependencies #43

Merged
merged 4 commits into from
Apr 6, 2021
Merged

Make target to download binaries dependencies #43

merged 4 commits into from
Apr 6, 2021

Conversation

luizbafilho
Copy link
Contributor

I mostly brought the scripts from the wks repo.

palemtnrider
palemtnrider suggested changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@palemtnrider palemtnrider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have the binaries downloaded dynamically. I made a few minor comments. Looks like the functions file came from WKP - I'd suggest removing the functions we don't need.

tools/download-deps.sh Outdated Show resolved Hide resolved
tools/download-deps.sh Show resolved Hide resolved
tools/download-deps.sh Show resolved Hide resolved
tools/download-deps.sh Outdated Show resolved Hide resolved
tools/functions.sh Outdated Show resolved Hide resolved
tools/functions.sh Outdated Show resolved Hide resolved
@luizbafilho luizbafilho mentioned this pull request Apr 5, 2021
Merged
@luizbafilho luizbafilho linked an issue Apr 5, 2021 that may be closed by this pull request
Make target to download and install dependencies #33
Closed
J-Thompson12
J-Thompson12 approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@J-Thompson12 J-Thompson12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luizbafilho luizbafilho merged commit 0e34346 into main Apr 6, 2021
@luizbafilho luizbafilho deleted the issue-33-download-dependencies branch April 6, 2021 16:07
@luizbafilho luizbafilho restored the issue-33-download-dependencies branch December 8, 2021 17:35
@bigkevmcd bigkevmcd deleted the issue-33-download-dependencies branch December 15, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-Thompson12 J-Thompson12 J-Thompson12 approved these changes

@palemtnrider palemtnrider Awaiting requested review from palemtnrider

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make target to download and install dependencies
3 participants
@luizbafilho @palemtnrider @J-Thompson12