Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding wego-controller #46

Merged
merged 7 commits into from
Apr 7, 2021
Merged

Adding wego-controller #46

merged 7 commits into from
Apr 7, 2021

Conversation

luizbafilho
Copy link
Contributor

@luizbafilho luizbafilho commented Apr 6, 2021 •
edited
Loading

fixes #37 #38

@luizbafilho luizbafilho linked an issue Apr 6, 2021 that may be closed by this pull request
Scaffold the wego controller #37
Closed
@luizbafilho luizbafilho self-assigned this Apr 6, 2021
@luizbafilho luizbafilho linked an issue Apr 7, 2021 that may be closed by this pull request
Add github action workflow to publish wego controller image #38
Closed
jrryjcksn
jrryjcksn approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@jrryjcksn jrryjcksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good (to the extent that I understand all of it). How much of it isn't generated? Only issue is my question about go 1.13

controllers/wego-controller/Dockerfile Outdated
@@ -0,0 +1,27 @@
# Build the manager binary
FROM golang:1.13 as builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why go 1.13?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. that's the default generated in the init command, I'll change it.

@luizbafilho luizbafilho merged commit 77f2220 into main Apr 7, 2021
@luizbafilho luizbafilho deleted the wego-controller branch April 7, 2021 21:26
@luizbafilho luizbafilho restored the wego-controller branch December 8, 2021 17:35
@bigkevmcd bigkevmcd deleted the wego-controller branch December 15, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrryjcksn jrryjcksn jrryjcksn approved these changes

Assignees

@luizbafilho luizbafilho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add github action workflow to publish wego controller image Scaffold the wego controller
2 participants
@luizbafilho @jrryjcksn