Refactor test script #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iahmad9
reviewed
Apr 26, 2021
|
|
||
| BeforeEach(func() { | ||
|
|
||
| Context("Given I have a wego binary installed on my local machine", func() { | ||
| Expect(FileExists(WEGO_BIN_PATH)).To(BeTrue()) | ||
| }) |
There was a problem hiding this comment.
I think Context container is not recommended to be used in BeforeEach or It blocks, instead it is preferred to keep them outside. Any particular reason for using it in this way?
There was a problem hiding this comment.
It was the only way I could make the script run... I wanted to run the Given condition before each test case but the hierarchy of Describe, Context, It, & By was giving me problems.
There was a problem hiding this comment.
I've changed Context to By — seems to work just fine.
iahmad9
reviewed
Apr 26, 2021
| var _ = Describe("WEGO Acceptance Tests", func() { | ||
|
|
||
| var session *gexec.Session | ||
| var err error |
iahmad9
approved these changes
Apr 29, 2021
iahmad9
reviewed
Apr 29, 2021
test/acceptance/test/smoke_tests.go
Outdated
|
|
||
| It("Verify that wego flux can print out version information", func() { | ||
|
|
||
| By("When I run 'wego flux -- -version", func() { |
There was a problem hiding this comment.
would be good if this is changed to wego flux -- -v as that's what the test case is testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the test script to make code more reusable