Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

weaveproxy stub breaks Docker restart policies #1209

Closed
bboreham opened this issue Jul 22, 2015 · 1 comment
Closed

weaveproxy stub breaks Docker restart policies #1209

bboreham opened this issue Jul 22, 2015 · 1 comment
Assignees
@bboreham
Labels
bug [component/proxy]
Milestone
1.1.0

Comments

@bboreham
Copy link
Contributor

The weavewait stub, which we use to coordinate network set-up when containers are started via the weave docker API proxy, relies on the proxy sending it a SIGUSR2.

As noted at moby/moby#11065, this breaks any docker restart policy, e.g. docker run --restart=always.
@bboreham bboreham self-assigned this Jul 23, 2015
@bboreham
Copy link
Contributor Author

We could just signal the container directly, but that requires --pid=host which means a newer docker.

Related: #578

@rade rade closed this as completed Jul 23, 2015
@rade rade reopened this Jul 23, 2015
@rade rade added this to the 1.1.0 milestone Jul 23, 2015
@bboreham bboreham mentioned this issue Jul 23, 2015
Merged
@rade rade modified the milestone: 1.1.0 Aug 5, 2015
@rade rade mentioned this issue Aug 13, 2015
Closed
@bboreham bboreham mentioned this issue Aug 17, 2015
Merged
rade added a commit that referenced this issue Aug 28, 2015
@rade
Merge pull request #1314 from weaveworks/1209-wait-iface-netlink
6291a89 
Wait for ethwe via netlink, not via polling or signals

Fixes #1209. Fixes #1258. Fixes #1300.
@rade rade modified the milestone: 1.1.0 Aug 29, 2015
@rade rade mentioned this issue Jan 28, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bboreham bboreham

Labels
bug [component/proxy]
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@rade @bboreham